90

koihia
For me it's not reliable with or without the built-in content blocker enabled. I don't think it matters.

    3 months later

    Steps to reproduce:
    <Include steps to reproduce the bug; Did you try using Compatibility mode? If applicable, does Safari behave in the same way?>

    1. Open a webpage
    2. Ads get blocked by uBlock origin
    3. But certain cosmetic filters or blank areas where the ads used to be are not properly removed
    4. Refresh the page to see how it's supposed to actually look.

    Expected behavior:
    <What you expected to happen?>
    Not needing to refresh the page every time I visit a webpage for uBlock to work properly.

    Orion, OS version; hardware type:
    Orion Version 0.99.115.1-beta (WebKit 614.1.12)
    macOS Monterey Version 12.5 Beta (21G5046c)
    MacBook Pro (Retina, 15-inch, Mid 2015)

    Image/Video:
    <Copy/paste or drag and drop to upload images or videos (up to 20MB)>

      5 days later

      Partially fixed with the Version 0.99.115.2-beta (WebKit 614.1.12) update, some pages are still janky like when you open a page in a new window or tab. Besides that, there's still a noticeable delay for when the cosmetic filter is properly applied and you can briefly see the placeholder area before it gets blocked.

      • Vlad replied to this.
        6 days later

        gurohime We will need more details than this - exact steps to reproduce.

          3 months later
          Merged 4 posts from UBlock not effectively applying cosmetic filters on most pages.

            szlend Thanks. Note there is a cool feature under Reply menu -> Flag -> Mark as Duplicate that lets you do exactly this

            a month later

            I have managed to find a specific example for this @Vlad.
            Here are the steps to reproduce this along with the video for it on : https://music.youtube.com

            Steps are as follow :-

            1. Just after install simply install the ublock origin extension.
            2. Open youtube music and play any song and ublock will work as expected.
            3. Now open the preferences and disable content blockers (in-built ones)
            4. Quit the browser
            5. Reopen the browser
            6. Again revisit youtube music and play any song and now the ads will show up.

            Btw, this is not just for ublock but also happens for other ad blockers like adguard as well. The reason for disabling the in-built content blockers is the FAQ mentions to not use them side by side with ublock here :- https://browser.kagi.com/faq.html#ubo

            It seems like disable in-built content blockers is somehow messing up with the 3rd party blockers like ublock
            Hope you are able to reproduce this and test out on your end and then maybe we can have a fix for this.

              anmol Does uBo block anything for you (when content blockers are disabled)?

                @Vlad it does work on some sites correctly when the content blockers are disabled. For eg. On youtube.com it does work but then doesn't on music.youtube.com.

                  11 days later

                  anmol Vlad
                  I wonder if this is a different issue altogether, or if this is because of the different ways you load the site the first time vs. the second time. The first time you enter music.youtube.com, you have to click on the privacy agreement, which results in the page being refreshed. And that sounds oddly familiar to the steps to reproduce I posted a while ago (see szlend). I'm able to reproduce the inconsistent uBlock behaviour regardless of whether Orion's content blocking is enabled or not.

                  The fact that this can be resolved by a tab refresh leads me to speculate it has something to do with how uBlock gets initialized in a fresh tab vs. a reused one.

                  @Vlad I can only reproduce the issue with uBlock Origin cosmetic (DOM element) filters when the page loads in a new tab, which I think is a major clue.

                  Scenario 1:

                  1. We have site A and B
                  2. Using uBlock Origin, block a DOM element on website B
                  3. Click on a link on website A that leads to website B in the same tab
                  4. uBlock Origin successfully blocks the DOM element

                  Scenario 2:

                  1. We have site A and B
                  2. Using uBlock Origin, block a DOM element on website B
                  3. Click on a link on website A that leads to website B in a new tab (target="_blank")
                  4. uBlock Origin fails to blocks the DOM element
                  5. Refresh the page
                  6. uBlock Origin successfully blocks the DOM element

                  I can reproduce this every single time. In practice this results in most external links (as they're often configured to open in a new tab) not being adblocked properly, which is frustrating. All links to social media content (e.g. Twitter, YouTube) are typically opened with target=_blank.

                  I think it's possible that people correlate this with Orion's content blockers being disabled because those will often block the same content. So disabling Orion's content blocker make the issue more likely to appear as uBlock Origin's flakiness is more apparent. I suggest testing with custom uBlock filters for this reason.

                  It seems to be pretty consistent behavior but I can't quite explain it in simple words because despite the consistent way it works (or doesn't), there's some outliers (like the first navigation from the start page in a new private window blocking correctly).

                  I recorded a video to show you, hope it helps.
                  Edit: I should have show in the beginning of the video instead of the end: the cookie banner at the bottom of reddit should be hidden via a uBlock Origin filter on its HTML #id

                  Version 0.99.121.1-beta (WebKit 614.1.20)
                  MacBook Pro (macOS Catalina 10.15.7 build 19H2026)

                  9 days later

                  Is someone able to summarize a minimal ask from this entire thread for us to look at - so many things here to parse. Thanks.

                    Vlad

                    Basically to sum it up, uBlock Origin cosmetic (DOM) filtering sometimes doesn't work. It seems to be correlated with the way the page loads (Fresh tab vs Reused tab). It's hard to say if this is the real reason (it might be a different underlying issue), but I'm able to reproduce 100% of the time with this method. I'll copy the test scenarios from a previous post:

                    Scenario 1:

                    1. We have websites A and B
                    2. Using uBlock Origin, block a DOM element on website B
                    3. Click on a link on website A that leads to website B in the same tab
                    4. uBlock Origin successfully blocks the DOM element

                    Scenario 2:

                    1. We have websites A and B
                    2. Using uBlock Origin, block a DOM element on website B
                    3. Click on a link on website A that leads to website B in a new tab (target="_blank")
                    4. uBlock Origin fails to blocks the DOM element
                    5. Refresh the page
                    6. uBlock Origin successfully blocks the DOM element

                    Does that make sense? Let me know if there's anything else I can do to help.

                      Steps to reproduce:
                      Click on element picker mode on ublock origin's UI on one of the following sites: https://www.espncricinfo.com, https://news.ycombinator.com/news

                      Expected behavior:
                      Mouse cursor should be a picker icon, and element being hovered on should have a red overlay. There should be an interface for specifying the blocking filter.

                      It does work on some sites like reddit.com, but doesn't work on others.

                      Orion, OS version; hardware type:
                      Version 0.99.112-beta (WebKit 614.1.1), Mac Mini M1, Monterey 12.2

                      Image/Video:
                      Doesn't work:

                      Works but not on the Promoted elements:

                        a year later

                        Came here to report the same. Good to see there's a topic already.

                        Element zapper mode and element picker mode are not functioning on some websites.

                        Version 0.99.123.1-beta (WebKit 615.1.16.1)
                        uBlock Origin 1.44.2

                        • Vlad replied to this.
                          Merged 4 posts from Ublock origin element picker mode doesn't always work.