Steps to reproduce:
- Open Twitter/Youtube
- See the favicon
Expected behavior:
Normal quality of favicons
Orion, OS version; hardware type:
Orion RC 0.99.124.1.1-rc (WebKit 616.1.14.11.1)
macOS Version 13.4 (Build 22F66)
Image/Video:
Steps to reproduce:
Expected behavior:
Normal quality of favicons
Orion, OS version; hardware type:
Orion RC 0.99.124.1.1-rc (WebKit 616.1.14.11.1)
macOS Version 13.4 (Build 22F66)
Image/Video:
I tested some more using the script i showed above.
And i actually think that alot of the improper favicons are actually just due to Orion not updating them per page. the reason i suspect that is one of the examples here of a wrong favicon is IMDB
Orion:
Safari:
When you visit IMDB in Orion and run the script it looks like this:
But if you go in search bar on Safari and try type IMDB Siri suggestions shows this:
And as soon as you enter the site the favicon changes to this:
Which makes me bellieve that Siri is fetching the base URL favicon, and then updating it when it enters the site.
So the reason why Orion displays the "wrong" favicon is because this update never happens.
IFixit is another example.
So bottom line is that fixing Orion updating favicons continuously would propably also fix most of the mentioned examples of "wrong" favicons.
and fix this:
https://orionfeedback.org/d/420-favicon-on-open-tab-does-not-update-when-sites-favicon-updates/13
found this:
https://firefox-source-docs.mozilla.org/browser/places/notifyObservers.html
https://searchfox.org/mozilla-central/source/dom/chrome-webidl/PlacesEvent.webidl
looks like thats how firefox does it, doesnt look too complicated
would most likely also fix this:
https://orionfeedback.org/d/3111-google-docs-favicons-are-incorrect/7
Steps to reproduce:
Open Google docs/slides/sheeys
Expected behavior:
Correct favicon per app
Orion, OS version; hardware type:
Version 0.99.120.1-beta (WebKit 614.1.20)
MacBook Pro M1 Pro (macOS Monterey 12.5.1 build 21G83)
Image/Video:
i believe this is bc orion allocates one favicon per root domain, instead of including other pages?
Steps to reproduce:
Open google docs, slides, or sheets
Expected behavior:
Correct favicons for each webapp
Orion, OS version; hardware type:
Version 0.99.120.1-beta (WebKit 614.1.20), Macbook Pro M1 Pro (macOS Monterey 12.5.1 (21G83))
Image/Video:
these should be google sheets, google docs, and google docs.
Still in a thing in latest version of Orion (
using Version 0.99.121-beta (WebKit 614.1.20)
I can also confirm this to be an issue in the latest beta.
Steps to reproduce:
Expected behavior:
To see good quality of favicon, for example, like Notion (see the screenshot)
Orion, OS version; hardware type:
App version: 1.2.9 (1) (WebKit 8615.2.9.10.3)
System version: 16.5.0
Device type: iPhone 11
Native bounds: (828.0, 1792.0)
Scale: 2.0
Regular tabs: 1/1/1/orion://newtab/
Private tabs: 0/0/0/(
Image/Video:
This is only fixed partially in RC. I think one of the reasons its only partially is because this still doesnt work:
https://orionfeedback.org/d/420-favicon-on-open-tab-does-not-update-when-sites-favicon-updates
an example is github when going from light mode to dark mode, or the other way around
By using the script posted earlier i see that Orion remembers the dark mode favicon from the first time i visited the website, and never updates it when it changed
I speculate this will cause other issues aswell, as for instance fetching the discord unread favicon at the time of loading website. and then displaying that count regardless of how many unread you actually have.
So i think to only way to properly fix this is to also fix the other issue. i posted documentation of how firefox does it further up
As far as i understand (no code master), it just checks for new favicon when specific events are fired. like url change or tittle change etc..
I dont see how its different. the result is "improper favicon"which is the tittle of this thread.
So the point is that "Blurry or improper favicon" most likely cant be fixed fully without at least partially fixing the other issue
Theres is nothing really new in what I'm saying in regards to the other issue, so its not interesting for the other thread. Its only interesting for this issue of improper favicon
--
Also after thinking about it, perhaps my example of github dark mode/light mode can be fixed without fixing the other fully.
Since it isnt the favicon dynamically updating, its the website sending a different favicon dependent on users having dark mode or light mode on. and Orion storing the favicon without any log if it was either or, and not asking for a new one on refresh.
Which potentially can lead to other issues as mentioned above (discord message count being wrong). another example of issues it could perhaps create is if a website changed there favicon. and Orion just keeps the favicon it had when first visiting