Blurry or improper favicon

I did some tests. and found several problems with Orion and Favicons.

some websites have different favicon depending on if the system is in dark mode or not. GitHub is one example.
that is to avoid having black icon on dark background.

If you visit github in light mode. and then the system swith to dark mode, Orion will remember favicon from light mode instead of checking for a new favicon. resulting in this:

Makes it very hard to tell what website you have open, It will keep that favicon even if you open a new tab and go to the site

I think this is related to 2. mentioned by eirk futher up. so unlike website titles that dynamically change in Orion favicons are static, so i guess tittles do checks all the time so the tittle update, favicons should do the same

Discord is a good example:

Tittle change, Favicon does not.

I did this script you can copy into a Programmable Button. that will display what favicon should be shown:

var favicon = document.querySelector('link[rel="icon"]') || document.querySelector('link[rel="shortcut icon"]');
var faviconUrl = favicon.href;

var faviconImage = document.createElement('img');
faviconImage.src = faviconUrl;
faviconImage.style.position = 'fixed';
faviconImage.style.top = '10px';  // Adjust the position as needed
faviconImage.style.left = '10px';  // Adjust the position as needed
faviconImage.style.zIndex = '9999';  // Set a high z-index to ensure it's displayed on top
faviconImage.style.pointerEvents = 'none';  // Make it non-interactive

document.body.appendChild(faviconImage);

That script shows this icon:

found this:

https://firefox-source-docs.mozilla.org/browser/places/notifyObservers.html

https://searchfox.org/mozilla-central/source/dom/chrome-webidl/PlacesEvent.webidl

looks like thats how firefox does it, doesnt look too complicated

Steps to reproduce:
Open google docs, slides, or sheets

Expected behavior:
Correct favicons for each webapp

Orion, OS version; hardware type:
Version 0.99.120.1-beta (WebKit 614.1.20), Macbook Pro M1 Pro (macOS Monterey 12.5.1 (21G83))

Image/Video:

these should be google sheets, google docs, and google docs.

This is only fixed partially in RC. I think one of the reasons its only partially is because this still doesnt work:

https://orionfeedback.org/d/420-favicon-on-open-tab-does-not-update-when-sites-favicon-updates

an example is github when going from light mode to dark mode, or the other way around

By using the script posted earlier i see that Orion remembers the dark mode favicon from the first time i visited the website, and never updates it when it changed

I speculate this will cause other issues aswell, as for instance fetching the discord unread favicon at the time of loading website. and then displaying that count regardless of how many unread you actually have.

So i think to only way to properly fix this is to also fix the other issue. i posted documentation of how firefox does it further up