Improvements to PIP video feature

catch-22

The current PIP implementation in Orion is satisfactory, however it still needs a few improvements to be at the level of other browsers:

Clicking on the X button on a PIP video should not bring the tab and window into focus. That should only happen when clicking on the PIP button (which sends the video back to its tab)
Resizing a PIP video window that is playing should be smoother, currently it freezes a lot when resizing
Sometimes the control + cmd + P shortcut does not work without interacting with the video first (i.e. pausing and resuming playback). I found that the most reliable way to reproduce this is to have the video auto-playing setting on, head to YouTube, play any video, and try the shortcut. A lot of the times it won't work
Having the option to have a toolbar icon as a shortcut would also be nice

Vlad

catch-22 Can you record a video of it freezing while resizing?

What would toolbar icon do (if video is not playing and if PiP video is playing?)

catch-22

Vlad Ok I'll record a video when I get a chance.

A toolbar icon would do exactly the same as the existing control + cmd + P shortcut, it would be up to the user to decide whether to use the shortcut or the icon (or whereas to even have the icon in the toolbar).

I personally prefer having a toolbar icon as I can just click on it with the mouse without needing to use both hands for a keyboard shortcut.

catch-22

Vlad video of the PIP video window resizing glitch

h2flux

While I can't speak on the other things you brought up as I haven't experienced them myself, I do want to say that I don't think an icon in the menu bar would be necessary.

saul

h2flux Doesn't have to be mandatory. There's a number of toolbar icons available that are not enabled by default. I don't see anything wrong with having a PiP icon for those that wish to use it

catch-22

saul Exactly, my whole point was to have an option to have a toolbar icon

Vlad

catch-22 As a note it is useful to break down big features to smaller separate issues. This issue now consists of several unrelated issues (resize glitch and toolbar icon are different things). As it is it would enter roadmap as a very large card which could delay it for a long time. Making a few smaller issues separately could help get to results faster (ie toolbar icon). No action needed now as I will manage it but FYI for future.

catch-22

Vlad yes you're right, I'll do it in future occasions