25

Steps to reproduce:
<Include steps to reproduce the bug; Did you try using Compatibility mode? If applicable, does Safari behave in the same way?>
Extension is here:
https://chrome.google.com/webstore/detail/readwise-highlighter/jjhefcfhmnkfeepcpnilbbkaadhngkbi
or here:
https://addons.mozilla.org/en-US/firefox/addon/readwise-highlighter/

Expected behavior:
<What you expected to happen?>

This is related to Readwise's beta product (Reader) so might be problematic to test without access to Reader. However, extension is supposed to send URL and any highlights to Reader. Practically, nothing happens when it's clicked.
Console shows:
"SyntaxError: Invalid regular expression: invalid group specifier name". Screen capture with full error message included.

Orion, OS version; hardware type:
Orion Version 0.99.115.3-beta (WebKit 614.1.12)
OS MacOS Monterey 12.4, Mac Mini M1

Image/Video:
<Copy/paste or drag and drop to upload images or videos (up to 20MB)>

    7 months later
    a month later

    I would love to get this working too. It's a great read later service. Currently, I use the bookmarklet they provide, but because of that I need to have the bookmarks bar visible.

      2 months later

      @Vlad Any news on this one?

      I get the following pop up when I try to save a page from the Chrome extension…

      I get this with both the Firefox and the Chrome extension. Seems it can't wrap the page.

      • Vlad replied to this.

        janpeeters Do you think there are no news because I forgot to post about them, or because this is one out of 2000 open issues on the site (and one out of 300,000 web extensions out there) and we have only two developers? 🙂

          @Vlad I get the impression that I stepped on your toes with my question and that these kinds of questions annoy you. Could it be that since the process after a report is like a black box, which I can understand if there are only two devs, that people just ask a question because they are curious about the state of affairs?

            janpeeters I value your contribution. Here is how things look from my perspective:

            • State of affairs is indicated on the thread and it is "Under review"> Almost every extension issue is under review because we in general do not solve problems extension by extensions (unless they are hugely popular extensions) but wait for the proper API support to land in Orion

            • It is part of my job to read every comment on this website and to reply to them. I have made over 5,000 replies on this website already, you can imagine how much time that has taken and amount of context switching it requires. How many CEOs you know who do that?

            • If everybody suddenly decided to ask about the state of affairs for every post I would be facing several thousand new messages to see and reply to every week (it is a few hundred weekly currently)

            • Thus it is important to me to convey what I did above, otherwise things would start to fall apart and this forum would become useless

            • It is currently definetely not useless as the issues get prioritized (based on upvotes, impact to entire user base and complexity), and the flow of tickets is transparent and evident by the release notes

            • Sorry if it sounded rude, after you do this so many times, there is very little empathy left in the tank

            @Vlad thanks for clarifying your perspective. Makes things clear. And I, of course, appreciate your work. And no offense taken by your reply after reading this.

            What I didn't know is the two devs situation and that you don't fix extensions on an extension by extension way. Logical, of course, but I didn't realize that. That clarifies why some extensions take longer to get working.

            Because two (for me) essential extensions don't work, I see myself using Arc more and more. That's not something I really fancy because Orion still is my favorite browser. I love its philosophy, privacy and clean design. But my productivity also needs to stay up. My inquiry was part of my wish to be able to use Orion for those activities like saving content to Readwise and Obsidian as well.

            I'll keep my eye on the statuses and will not bother you with inquiries. You're right, that just creates an extra workload for you, and energy drain. And that is not my intention.

            I could imagine the endeavor to get Chrome and Firefox extensions working in a WebKit browser can sometimes feel like an endless stream of issues.
            Thanks again, best, Jan

            4 months later

            Just wanted to chime in and let anyone who finds this know that the extension is now working on Orion 0.99

            I installed the Firefox version of the Readwise Highlighter app directly from the store page and it works for me, including the in-page highlighting context menus saved back to Readwise.

            Here is the firefox extension link:
            https://addons.mozilla.org/en-US/firefox/addon/readwise-highlighter/

            Not sure if it was work that Readwise did or that the Orion team did, but either way it got fixed by someone. Both apps (Readwise Read and Orion Browser) are beta products. So it isn't terribly surprising that there were hiccups. But either way, it works now!

            (At least the Firefox one does, i never tried Chrome and try to avoid that store if possible)

            Happy highlighting!

              Vlad

              I am using:

              Orion
              Version 0.99.125-beta (WebKit 616.1.22)
              Build date Jul 31 2023
              MacBook Pro (macOS Ventura 13.4.1 (c) build 22F770820d)

                Also heads up to everyone, for whatever reason, the plugin extension didn't work with any tabs that were opened prior to the install of the extension. I would get the reload tab message, and reloading would just have it ask again.

                The solution that worked is to just close the tab, open the same website up in a new tab and now it would work. I replicated this a few times and it seems that no matter how times you reload or navigate around, any tabs that were open before I installed the extension didn't work until I closed them, then it worked ever since.

                So my advice is to just restart the browser after installing the extension. With a fresh browser, then all the tabs will recognize the extension and have worked for me ever since. I have tested it on about 25 or so different websites and so far it has worked on everything after the browser restart. And it has worked across multiple restarts too.

                a month later
                a year later

                There's a regression with the Readwise Highlighter extension. The Chrome version doesn't work at all, clicking the icon does nothing. The Firefox version shows a notification 'reload the tab', but reloading the tab doesn't make it capture the page.

                Thanks for having a look at this. I use it a a lot and have to revert to another browser because of this.

                Jan

                • Vlad replied to this.

                  janpeeters It may not be a regression, but the extension adding new features or extensions APIs we do not support yet. have you tried with the same version that was active at the time this was marked as done?

                    @Vlad Good point, but after researching your remark the Firefox extension seems to not have not been changed recently. And I've been using it over the last months without a problem. It started with the last RC release.

                    Latest version
                    Version 0.15.23
                    Released Jan 16, 2024 - 2.75 MB
                    Works with firefox 48.0 and later

                    Thanks for looking into this one 🙏. Also a daily driver for me

                      a month later
                      15 days later

                      Had same issue with Firefox and Chrome versions. Just tried the Safari one as well and same behavior as Chrome (nothing happens after clicking the button. I never get a "Connect Readwise account" page and the page doesn't save. It's basically a no-op.

                      6 days later

                      @Vlad any chance it'd be possible to fix this extension. It has a fairly large userbase and I'm sure there's a lot of overlap with Orion users. It's the one thing that's making it hard for me to switch to Orion for good 🙂.

                        Ishan It is planned, but so are more than a 1000 other user requests. How would you prioritize them?

                          Vlad Yeah I figured, thought I'd just try my luck haha. Appreciate all the hard work you and your team have been putting in with all the amazing products 🙏

                          This is probably a stupid idea but there's no way to open-source just the extensions compatibility aspect of Orion right? So that it can be crowd sourced - what with so many extensions out there and platform changes on the extensions etc

                          • Vlad replied to this.

                            Ishan

                            Yeah I figured, thought I'd just try my luck haha.

                            It creates a notification and since we read every single comment (and often respond) it produces a counter effect of team spending time reading unecessary comments vs working on actual bug reports.

                              Vlad My comment came from a good place of trying to help Kagi because it's the one blocker for me to switch to Orion, and I know readwise has a big community so imagined there's others like me who aren't switching because of it. Your tone so often with people in your community though is of annoyance, when we're all cheering for you and your company and trying to help. That's fine - I will cancel my Kagi ultimate account and use another product. Thanks.

                                Ishan

                                You're right - I was unnecessarily harsh. While your repeated comments do create overhead, you're a paying customer trying to help. That's valuable, even when it's spreading us too thin.

                                The Readwise extension is noted. We'll get to it when we can.

                                  a month later

                                  Same issue on iPadOS

                                    Hey there,

                                    I'm a heavy Readwise user myself and finally got around to looking into the errors surfaced by the Readwise extension.

                                    Locally, I was able to hack up the extension to get it running.

                                    While I've attached my locally patched version to this post, it should go without saying that you probably shouldn't trust random zip files from strangers, myself included. If in doubt, you can grab your own copy of the extension and make the modifications manually by following the steps below.

                                    With that, this post is mainly aimed at Orion devs, it'll be pretty verbose and boring.

                                    To start with, I tried all three extensions (Chrome, Firefox and Safari).

                                    As a side note, the Chrome extension was downloaded as a zip file using the CRX Extractor/Downloader extension. Firefox natively allows downloading XPI files and Safari downloads extension packages (.app) to /Applications.

                                    All three variants mostly share the same DNA, although with some slight alterations. At a glance, Chrome and Safari are actually much closer than Firefox but I didn't dive too much into these differences as my goal was just getting something working for my own use after all.

                                    Starting with the Firefox extension, pointing the dev tools console at the extension view shows up the following error:

                                    Failed to load resource: The operation could not be completed. (Orion.SchemeHandlerError error 2.)

                                    Off the bat, this smelled like something on Orion's end so I pretty quickly pivoted to the other extensions and didn't dig any further with Firefox.

                                    When first installing the Chrome and Safari (via Tools -> Extensions -> Install From Disk...), nothing will appear to happen. Digging into the console, we're presented with an interesting error and our first hint of trouble.

                                    SyntaxError: Can't create duplicate variable that shadows a global property: 'window'

                                    Sure enough, the extension is has some code in background/index.js that is fiddling with the global Window variable:

                                    const window = globalThis;
                                    window.crypto = crypto;
                                    globalThis.global = globalThis;
                                    globalThis.window = window;

                                    I couldn't find anything to actually cite but it seems that the shadowing of globals is a quirk of WebKit? I'm not entirely sure I believe it though because this exact same code is in the Safari extension, which runs just fine. It only seems to trigger when loaded into Orion (either via the Safari or Chrome extensions)

                                    To work past this, I modified this block of code like so to sidestep the shadowing issues:

                                    const _window = globalThis;
                                    _window.crypto = crypto;
                                    globalThis.global = globalThis;
                                    globalThis.window = _window;

                                    Carrying on, we run into our next issue:

                                    Error: !isRunningInExtensionBackground

                                    If we dig into the (minified) function Ype, which calls the (minified) function Lhe, we see the following:

                                    This function consists of two checks: aE() and a check to see that self.registration exists.

                                    aE() consists of a bunch of other functions which all evaluate to true but self.registration does not exist and so the Lhe check fails which raises the !isRunningInExtensionBackground check failure we see.

                                    After a bit of digging, I discovered that self.registration is part of the ServiceWorkerGlobalScope.

                                    If we jump over to Chrome, inspect the registered service worker view and query the window object, sure enough we see that there is a registration function.

                                    As far as I can tell, Orion either doesn't register or surface a service worker view for the extension. If there is one, I couldn't find it clicking around.

                                    With another edit in the extension code to delete two of the "registration" in self checks, I reinstalled the extension and with that, everything starts working just fine.

                                    As a bonus tip, I noticed a few checks in the Chrome extension that would infer whether the browser was Safari based on the browser's internal navigator string.

                                    Because the Orion navigator includes both Chrome and Safari, the Chrome extension thinks that it's running inside of Chrome. This may actually end up being fine if the Chrome APIs it's trying to call do actually exist though.

                                    Anyway, with that, I now have a working (static) version of the extension running on my laptop and it doesn't seem to have any further issues even though the service worker check was stubbed out.

                                    I did also try installing it briefly on my phone, which worked although I couldn't get it to seemingly trigger. I didn't bother trying to debug the extension remotely (which would be a next step) as I realised that it's a bit pointless to install on mobile when I can trigger the same functionality from the Share Sheet thanks to the native iOS application 😛

                                    As a standard disclaimer, you should never trust random links you see on the internet and do your own vetting.

                                    With that out of the way, there's a patched version of the 0.16.7 Chrome extension to try in the meantime.

                                    I don't/can't offer any guarantees that it will continue to work whenever the next update releases and I won't be offering patches of any kind going forward just to be clear.

                                    readwise0167patched.zip
                                    3MB
                                    a month later

                                    🙌 As of today, the Firefox extension works correctly on:
                                    Version 0.99.131.0.1-beta (WebKit 621.1.2.111.4)
                                    Build date Feb 25 2025

                                      @pawel I tried it with the same versions but I'm not so lucky. Only the previous patched version from above works for me. Did you do any post install settings?

                                        janpeeters I didn't do anything except for installing it from the Firefox extension store — this extension specifically: Readwise Highlighter. It's worth noting that it didn't work on tabs loaded before the extension was installed, but new tabs worked as expected.

                                          No one is typing