Suspended tabs show domain but not page title
- Edited
The feature can allow users to quickly overview the saved tabs in a saved windows after reopening it.
It will allow users to see the name of each tab.
currently if you reopen a saved window you can't see the names of the tabs in that windows.
see video
- the user reopens a saved window from suspended state/not active.
- the user sees the names of each tab immediately (no need to expand the tree to see the subtabs) and the user doesn' need to click on each tab to reload it to see its name.
Here is how Safari handles it:
I found these:
https://orionfeedback.org/d/2442-suspended-tabs-show-domain-but-not-page-title
https://orionfeedback.org/d/6814-missing-tab-titles-in-vertical-tree-mode
https://orionfeedback.org/d/6721-side-tab-view-missing-titles-and-disorganized-on-restart
Related:
https://orionfeedback.org/d/5255-feature-focus-last-visited-tab-when-reopening-suspended-window
Possibly there are more, I went through first 20 pages of the 100+ pages of search results. My apologies for the delay, I put off this task too much.
Thanks for contributing @mazil!
And thanks to the Orion dev team for your work on the browser, I really like it already and use it a lot!
- Edited
When a window is suspended or orion is restarted. All of the tab names fall back to the URL names. These names are only restored on load. This makes inspection/organization of tabs hard as you basically need to reopen all tabs to get their real names.
I know that the name is persisted to the plist file .local_named_windows.plist
so this should hopefully a relatively simple lift.
Note: This may have implications for:
https://orionfeedback.org/d/79-tab-folders/22
- Edited
On restarting the application with side view tabs, tab heirarchies may be incorrect and tab titles may show domain names instead of the last title.
Reproduce:
- New profile
- Enable side view tabs
- Using side view tab pane, create a new window and name it
- In the new window, navigate to a website (I have verified this with wikipedia and youtube)
- Right click 2 links and open them in new tabs (should be heirarchal descendents of first tab)
- Move one of the new tabs above the first tab (should now be at the top level)
- Open the tab that was just moved
- Right click another link and open it in a new tab (there should now be 2 top level tabs each with 1 child)
- Suspend both top level trees
- Quit Orion (don't close window, fully quit profile)
- Start profile again: the moved tab will now be a child of the first tab again and some inactive tabs will have the domain name for a title
A couple of criticisms I have of my report and repro steps:
- there may be two separate issues here
- I have not tested anything similar for losing top view tab titles
- this series of steps may not be the most succinct. I'm not sure step 9, suspending, is really necessary nor whether rearranging the tabs is necessary to lose titles or what kinds of rearranging are necessary for organization to be lost
I could maybe provide screenshots or a video if desired.
When using side view tabs, reopen application with all tabs organized the same, all tab titles populated as before
0.99.126.3-beta (WebKit 618.1.2)
Sanoma (14.1.1)
It's not clear in my initial report but the repro steps are sort of the "best case" scenario. For example, I just restarted and the top level tabs are somewhat rearranged, children of various nested cases are now at the top level, etc. I'm hoping whatever solves the easy case I've demonstrated will be generalizable to the larger experience I have.
Furthermore, I've noticed some unexpected behavior with pinned tabs that feels related. I'm planning on delaying making a bug for that until after this is fixed as I also wonder if this fix will generalize to that. I can't neatly phrase the issue I've seen there without going through the effort to make it reproducible but I thought I would mention it in case it is of interest here.
straw_collector Appreciate the detailed report. Can you also add a video demonstrating this?
Attached a video. At 52 seconds in is the state I expect the browser to be in on restart:
- "test" window is open
- "Henry Kissinger" is top level and at the top
- All tabs have populated titles
At 1:03, "test" is not the open window. After opening "test" at 1:08, "Henry Kissinger" is a sub tab of "Wikipedia" and what was the sub tab of "Wikipedia" at closing now has the domain name title "en.wikipedia.org" rather than "United States Secretar..."
Note that this is of course a very simple demo. With enough nesting and tabs open from the same domain, a restart can really mess the tree up. This doesn't seem to be an issue in the default or maybe just unnamed windows.
- Edited
Also apologize for the subject matter I was just going for the top news link. Here's a succinct of before/after restart, red is tab movement and purple is missing title:
I see there's a planned status on this now but I'm not sure if that means root cause is understood or not. Out of curiosity I went digging for wherever this state is maintained and found information relevant to unnamed windows tabs in browser_state.plist and named windows tabs in .local_named_windows.plist. I'm not sure if these are the only places relevant info like this is maintained or if this is the source of truth when restarting the application, but I was able to somewhat observe the issue documented here in .local_named_windows.plist. I hope this is helpful, let me know if it's just noise.
The plist does not have correct tab window titles before closing the application and indeed on restarting the application it is those two tabs missing their titles, it's also the two which were children. I find the index field values to be curious as well as the two titled ones are both 0 and the two children are 2? After restarting and doing some navigation in both a previously correctly titled and not correctly titled tabs resulted in neither of their titles being correct and on restart I was able to see e.g. the New_Jersey url tab having Igneous intrusion title. After clicking through all 4 tabs their titles are now all en.wikipedia.org.
- Open a website.
- Pin the tab.
- Close Orion so it hibernates the tab.
- Open Orion.
- Right-click the hibernated tab and click bookmark.
- It has no title.
- It should have a title.
Version 0.99.126.4.1.9-rc
Sonoma (14)