6

This is an interesting one...

Steps to reproduce:

  1. For example, go to https://google.com.
  2. Activate search with ⌘F (cmd + F) and enter ‘g’.
  3. Count the number of g’s on the page.
  4. Compare your own count to Orion’s result.
  5. Notice that they are different.

Expected behavior:

  1. Orion should give the correct search results, matching your count.
  2. For reference, repeat the steps in Chrome and Firefox for the right answer.

Orion, OS version; hardware type:
Orion 0.99.110-beta (WebKit 613.1.12)
macOS 12.1

Image/Video:
Orion - 8 matches (wrong):

Safari - 2 matches 8 matches when “contains” is selected:

Chrome - 11 matches (correct):

Firefox - 11 matches (correct):

Side note: All the screenshots were taken in private browsing mode. https://orionfeedback.org/d/198-visual-distinction-between-private-and-non-private-windows

    I made a mistake in my Safari screenshot. Safari shows 8 matches too, same as Orion, when the “contains” search option is selected. I still prefer the results from Chrome and Firefox.

    • Vlad replied to this.

      adorabilis It looks like WebKit does not find text in html controls (buttons...).. Can you verify on other pages?

          adorabilis I guess I am trying to figure out what is the difference between Orion/Safari and Chrome on your screenshot

              Vlad I don’t understand what you mean by that. Orion/Safari found 8 matches on the page while Chrome found 8. Are you seeking further clarification or stating that you are in the process of debugging it?

              • Vlad replied to this.

                  adorabilis Your OP says Chrome has 11 matches so I am confused now.

                      It's a typo
                      They must have meant:

                      Vlad I don’t understand what you mean by that. Orion/Safari found 8 matches on the page while Chrome found 11. Are you seeking further clarification or stating that you are in the process of debugging it?

                        eirk

                        I guess I am trying to figure out what is the difference between Orion/Safari and Chrome in the execution of search

                        • eirk replied to this.

                            Vlad It seems like Orion can't search buttons in the following format:

                            <input value="can't be searched" type="submit" />
                            • Vlad replied to this.

                                Vlad Oops, sorry about the typo. Thank you @eirk for correcting me.

                                Just to be sure, I also checked the iOS versions. Since they are all WebKit, all missed the two buttons on https://google.com (desktop version). Orion, Chrome, Firefox produced the same result but Safari only searches with “begins with” as opposed to “contains”.

                                I wonder what WebKit’s logic behind this is. It’s strange that only a very specific type of button is excluded from search. Since Orion has plans to revamp search by integrating it into the address bar, is it possible to extend it beyond WebKit’s limitation to fix this weirdness?

                                    No one is typing