10

FF and Chromium ignore extension shortcuts which conflict with browser shortcuts and have separate menus in which all extension keyboard shortcuts are set and can be modified by the user.

Orion needs to both ignore shortcuts which conflict w/ browser shortcuts, and provide a UI to customise shortcuts as defined in extension manifests

    @Fortrikka
    If an extension overrides cmd n (new tab in browser) you would expect it to do so?

      5 months later

      Hello, me too I am experiencing trouble since none of my extensions shorctuts work. For example, to open Wallabager in Firefox I click on ⎇ + W, and in Orion if I click this nothing happens.

        It is not clear what the exact ask is here?

          8 months later

          I think this may be referred to search shortcuts. I also recently switched from firefox and I am an avid user of https://rust.extension.sh, where the extensions allows you to search docs just by typing rs in the url bar and then your query.

          I can go around this by using bangs (DDG or Kagi), but the extension also allows local caching and indexing also of local documentation, in addition to other libraries.

          I was very sad to see this feature disabled, or at least I wasn't able to use it in Orion after I installed the extension.

          EDIT: I realized now it meant keyboard shortcuts. I couldn't find another issue about the other type of shortcut I listed above tho...

            2 months later

            i think that the shortcut precedence should be (from highest to lowest)

            • app
            • extension
            • website

            so, the cmd-n shortcut can never be overridden.
            this also means that extensions can override shortcuts set by a website

              Bug Report

              Steps to reproduce:
              Minimize window shortcut while viewing a video on Netflix.

              Expected behavior:
              Minimize the tab.

              macOS:
              11.5

                Which one is the minimize window shortcut?

                I think it was you who asked that website shortcuts take precedence over app shortcuts (and we did that). What is your guidance?

                  7 days later

                  related discord messages:
                  @Fortrikka https://discord.com/channels/802933355603034132/897207822939455538/900975887082733600

                  … it would be nice if you could press "N" to create a new post

                  @Vlad https://discord.com/channels/802933355603034132/897207822939455538/902952419758075944

                  …keyboard shortcuts like \ and N are active now…

                  I don't know how website shortcuts used to work before, and how they're supposed to work according to standards.
                  But this is how it works in Safari:

                  • When on OrionFeedback cmd+N opens a new window, while only N opens the new feedback form.
                  • When on Netflix watching a video cmd+M minimizes the window, while only M toggles mute in the Netflix player

                  this is how it works in Orion:

                  • When on OrionFeedback cmd+N opens the new feedback form., while only N does nothing.
                  • When on Netflix watching a video cmd+M toggles mute in the Netflix player, while only M does nothing.

                    To add, I think "crucial" shortcuts should always override (new tab, new window, new incognito window, and focus address bar to name a few) however some of the auxiliary shortcuts (cmd + y for history, cmd + f for search, and cmd + u for focus mode for example) should pass through and prioritize any website shortcuts that may occur

                      Vlad Yes, it was me but Netflix does not use command+m. I use Safari and it works with Netflix and Youtube and also enables google meet's command+d shortcut to take precedence over Safari's own shortcut. It is a bit different in Orion's case.

                          saul The one tiny issue is that Google made command+D the bookmarking shortcut a shortcut to toggle the microphone in google meet.

                              pieterv It should be made to how it works in Safari as that is standard. Even in Google Chrome. I guess some issue is that the command key is being added even though both browsers are still webkit?

                                  @Fortrikka @saul @pieterv

                                  Help us understand how things should work. There is no such thing as a list of 'crucial shortcuts'. Based on the previous request, we have simply passed keyboard input to web app so it has precedence over browser.

                                  We appreciate concrete suggestions with examples. Thanks!

                                  • saul replied to this.

                                    Vlad I'm not too sure how Chromium does it, but it seems to handle passthrough quite well. In terms of "crucial shortcuts", these would be shortcuts that allow you to navigate the browser (cmd + Q, cmd + L, cmd + n, cmd + shift + N, cmd + T, cmd + shift + t, cmd + M, and probably a few others that I am forgetting).

                                    Essentially the goal is to pass the maximal amount of shortcuts through that don't cause you to lose any browser functionality

                                    • Vlad replied to this.