Custom PIP implementation

umr_1000

Vlad Any update for a potential PiP toolbar icon?

Vlad

posts that contain multiple feature requests are likely not to be considered any time soon. If you want things moved, please post a concrete, detailed description of one feature you want implemented. We'll take it one step at a time.

Longely

This is almost done now, only thing missing as far as i can see is:

Clicking on the X button on a PIP video should not bring the tab and window into focus. That should only happen when clicking on the PIP button (which sends the video back to its tab)

Sounds fairly simple

adamaveray

Brief Summary
Closing (not minimising) a floating picture-in-picture video from a non-foregrounded should simply close the video without refocussing the tab or Orion.

Details:
There are two ways to dismiss a picture-in-picture video on macOS: either closing it (with the × button), or returning it to the video (with the picture-in-picture icon button). Currently either action causes Orion to reactivate the video's originating tab, but only collapsing the video should return to the video's source – merely closing the video should not make any changes to which tab is focussed.

This focus switch happens no matter how the video is dismissed, whether by explicitly clicking the close button or by opening another video in picture-in-picture thereby causing the existing one to be dismissed. More jarringly, when another application is active and Orion itself is in the background, if the video's originating tab is not the active tab Orion will even steal focus and make itself the frontmost app when the video is closed.

For comparison, Safari correctly differentiates between the two actions and only makes focus changes when collapsing the video, not when closing.

OrionUser

Keyboard controls to fast forward, rewind, and pause.
It would be great if we could use the right and left arrow keys to fast forward and rewind, space bar to pause.

Button appears on video to enter PiP mode.
In Firefox you can have a "PiP button" appear when you mouse over a video playing, you can even have it show on the left or right side of a video. But this would a lot more convenient to enter PiP mode versus right clicking on the tab or going to the Menu bar for PiP. Keep all options but a PiP button showing up over the video (as an option to enable in settings) would be really nice.

Multiple PiP windows playing at the same time.
Being able to have more than 1 PiP playing at the same time. I know this might sound like over kill. But more options the better. I have a wide screen monitor. So it's common for me to have a podcast video playing and some YouTube ambient music video in the background. Or switching to a YouTube ambient music video and a news video. Or completely nerd overkill, YouTube, Netflix, and more YouTube lol. But yeah more options the better.

Place PiP window anywhere on the screen without holding the CMD key.
Right now you have to hold the CMD key down and move the PiP window where you want on your monitor. But if you move it without holding the CMD key it moves to the closest corner of your monitor.

Thanks 🙏 !

eirk

OrionUser

no, this is handled by webkit, not orion. see https://orionfeedback.org/d/2928-control-picture-in-picture-video-with-arrow-keys
no. see https://orionfeedback.org/d/1369-picture-in-picture-mode-button (tldr, shortcut and menu item exist, don't want to inject unnecessary stuff into webpage)
make a separate post for this
no, this is handled by webkit, not orion. see https://orionfeedback.org/d/2540-move-pip-more-freely/6

also please make one suggestion per post
otherwise its really hard to track individual requests

AlejandroHernandez

Perfect suggestions! – Especially a button to enter PiP. Or better yet like Opera or Arc does it, have an option to automatically switch to PiP when switching tabs.

Also please we need video controls. Right now we can only pause, which is veery limited.

Lastly, I feel like CMD should be used to snap to window corners and make it free-form when moving without holding a modifier. Why? Because most times you want to move this window freely. It's a bit annoying having to reach for the cmd key every time you want to just move it a bit.

Vlad

As a rule of thumb we do not automatically inject HTML to web pages to alter them (which is how Firefox adds that button). Button feels like it should be a part of the video control, not something browser should aritficially create.

AlejandroHernandez

Vlad Yeah I agree.

What about the way Opera does it:

It's an option to automatically pop out the window when you change tabs. It's so nice!

Right now when you switch tabs, you gotta find the tab where the video is playing and right click → and select show PiP. It's a lot of steps for something that most times someone would always want when switching tabs.

SptQ

i agree with having automatic activation of PiP when switching tabs or macos spaces, atleast as an option, its really useful on arc

also having video controls such as skip forwards / backwards 10 seconds would be good, but if its not in wekit's PiP then okay

Longely

SptQ

Would be a good idea to make a separate post for this if it doesn't exist. can see how it could be usefull

eirk

I feel arc implements some of these features pretty well, but I believe it uses its own custom PiP implementation, as I don't think chromium comes with one.

video:

What i think it does well:

freely moveable window, but also can align to edges
forward/backwards
progress bar on bottom

catch-22

eirk yeah I’m a big fan of its implementation in Arc. my favourite feature is that PIP video triggers automatically as soon as you navigate to another tab

viewsourc3

As of today, the PiP frame can only sit in one of the 4 corners of the screen.

I am wondering whether it would be possible to be able to drag the PiP to anywhere on the screen, a bit like this (this is Firefox's PiP feature)

Vlad

viewsourc3 Is it in Safari?

viewsourc3

Vlad from what I have experienced in Safari, PiP cannot be moved at all, and is only limited to sitting in the bottom left corner of the screen. PiP in Safari is also not as often available as in Orion, which seems to provide this feature a lot more constantly.
For example, PiP in Twitch is not available/possible on Safari, but is available on Orion.

Vlad

viewsourc3 I believe is PiP is managed by WebKit and this would probably be better made as a suggestion on WebKit issue tracker.