19

We would love if someone would summarize/consolidite this ask into one simple, focused ask

    2 months later

    Here's an example string ranking algorithm: https://sourcegraph.com/github.com/quicksilver/Quicksilver@a239587a6e890056c83bf7c120967bfba63cc917/-/blob/Quicksilver/Code-QuickStepCore/QSense.m

    Note that it's very sensitive to order, since it's usually used to search in filesystems, not in history entries:

    You can try a derivate of it here: https://fwextensions.github.io/quick-score-demo/, and compare it to other popular string ranking libraries, or even the original Quicksilver algorithm.

    Here's the json to try the examples @Gamma posted in Gamma:

    [
{"title": "github.com/borgbase/vorta: Desktop backup client for Borg backup", "url": "github.com/borgbase/vorta"},
{"title": "github.com/httpie/httpie: whatever", "url": "github.com/httpie/httpie"},
{"title": "tabby.sh: A terminal for a more modern age", "url": "tabby.sh"},
{"title": "borgbackup.org: Deduplicating with compression and authenticated encryption", "url": "borgbackup.org"},
{"title": "github.com/grafana/k6: A modern load testing tool", "url": "github.com/grafana/k6"}
]

    Note I have concatenated the title to the URL to be able to match across both, but it doesn't work for modern GitHub as the search term because of the aforementioned order sensitivity. There might be string ranking algorithms that are much more suited to this, or even ranking algorithms that can rank across multiple fields (you'll notice the example pages ranks url and title separately, then order by max score of either, that doesn't work for search strings that match partly in the url and partly in the title).

    This approach to ranking generally scales quite well as you can compute score for all candidates in parallel, and you can easily build the results up incrementally since new candidates do not modify the score of existing candidates, so are you find new hits you can easily insert them in the partial results that you're already displaying.

    Again note that the Quicksilver scoring algorithm specifically might not work well in practice for bookmarks / history, but I wanted to describe the concept of score ranking in general and it's is a very popular one.

        Gamma Can you describe the Orion behavior in this case curently? We did change the alogrithm several times.

            I can't speak for the specifics of @Gamma's use case, but the example they gave in the OP is still relevant, repro steps:

            1. Open https://orionfeedback.org/d/2224-better-search-in-history-from-address-bar
            2. Type "orionfeedback history" in address bar

            Expected: pages including orionfeedback and history in the url or title or combination of the two are suggested, including https://orionfeedback.org/d/2224-better-search-in-history-from-address-bar.
            Actual: nothing is suggested.

              Hi all,

              I don't think there is much I can add. What Firefox does is:

              • search into browsing history and bookmarks using all words you type in the address bar as substrings
              • search both in URL and Title
              • propose only matches that contain all of the words (it's an "AND" search)
              • sort by last visited time, descending (not sure)

              Looks pretty simple to me to implement and would be a significant improvement over what Orion does. In Orion, the moment you add a space and a second word all proposals disappear.

              Orion with one word:

              With two words, using "origin" which appears in the second row above (both in URL and title), I get no proposals:

              To the contrary here is firefox, searching "register" in the addressbar prompts for several matches from The Register:

              Now adding "stutte" that is a substring of the second URL:

              Or adding a second word that is part of the title (notice how Firefox highlights occurrences both in title and URL):

              I think the logic is:

              List results
for each site in (bookmarks, history)
        for each string in addressbar
               if site.url.contains(string) or site.title.contains(string)
                       results.add(site)
sortByLastVisitTimeDescending(results)
return results
              25 days later

              Hey, I just realised this seems to be implemented now!!!
              Cool!!!

              • Vlad replied to this.

                Gamma Are you trying this in the latest RC?

                    I am running Version 0.99.124.4.1-beta (WebKit 616.1.14.11.1)

                    And here is the search in the address bar:

                    Eerlier I would get no result as soon as I typed a space in the address bar

                    • Vlad replied to this.

                      Gamma Thanks for confirming, closing this.

                          No one is typing