The redesigned find on page clashes with the URL bar when using ergonomic appearance mode

laiz

Steps to reproduce the issue:

Install Orion 1.3.11 (3) (Testflight)
Set Orion appearance to Ergonomic
Go to any page or pdf file with text
Use the find on page feature
Swipe up to hide the keyboard and bring out the address bar
Notice the missing padding between the address bar and the find on page

Current App Store version behavior:

Expected functionality:
The Find bar and the address bar should creep onto each other's territories

Orion 1.3.11 (3)

Michal

Thanks for catching I'll fix asap

Michal

Fixed. Will be live in next TestFlight build

Michal

It should match Safari now. When the find in page is open and keyboard collapsed it should not show the expanded url bar it will be hidden

laiz

Michal
Nice work so far! It is definitely much better now.
However, unfortunately, I am still able to get the url bar to appear if I first scroll down and then up:

Michal

Damn you found one more way how to hide the keybord 😮
I'll try to find a fix but it's unlikely we land it in 1.3.11 which goes to AppStore release shortly. But it should be there for 1.3.12 if I find a good fix.

The logic between the new find on page and the toolbar state(expanded vs collapsed) is now separate so I have to manually prevent the toolbar from expanding from all the places it can expand from

Michal

From what I test now I do not see this keyboard dismissal on Safari when I try to scroll down or up. I wonder if it's something we manually invoke.
Are you able to dismiss the keyboard in a similar way on Safari while using find on page?

laiz

Michal Are you able to dismiss the keyboard in a similar way on Safari while using find on page?

The only way I've been able to dismiss the keyboard on Safari has been by tapping the Search key on the keyboard. Scrolling does not seem to affect the keyboard in any way.

Michal

Thanks for checking. So the issues is not that the bar is showing but that we dismiss the keyboard while find on page is active.
Let's see if I can find a fix

laiz

Hey @Michal
As of version 1.3.12 (1), the keyboard stays visible while scrolling, as is the case on Safari. However, I discovered one more edge case – hopefully this is the last one!

In text form:

Open Find on Page
Tap the blue Search button on the keyboard
The address bar still peeks from behind the Find on page element

For comparison, here's what happens when I repeat these steps on Safari:

laiz

Clean work @Michal 🍻
Everything works as expected on 1.3.12 (2) and the address bar knows its place.

Michal

Thanks for detailed tests on this one, it really helped