dino I have no problem using the Goodlinks extension in Firefox, including with Advanced Data Protection enabled. I'm able to sign in with my Apple ID as the extension requires, and have no issue saving pages to Goodlinks.
With Orion, I'm still unable to sign in with my Apple ID, as I mentioned in the OP.
Please consider reopening this ticket. It still seems to be an issue specific to Orion. I'm currently on Orion RC version 0.99.129.2-rc.
Edit: Please ignore the above. I was able to sign in with my Apple ID after ignoring the touchID input, and instead selecting "sign in with a different Apple ID" and signing in manually. All good now, Goodlinks extension works! It works on MacOS now. See second edit below:
Edit 2: Unfortunately, signing in with Apple ID for the Goodlinks extension is still broken on Orion in iOS. Clicking the button just turns it grey, and there is no further prompt or progress.