Blurry or improper favicon

This is only fixed partially in RC. I think one of the reasons its only partially is because this still doesnt work:

https://orionfeedback.org/d/420-favicon-on-open-tab-does-not-update-when-sites-favicon-updates

an example is github when going from light mode to dark mode, or the other way around

By using the script posted earlier i see that Orion remembers the dark mode favicon from the first time i visited the website, and never updates it when it changed

I speculate this will cause other issues aswell, as for instance fetching the discord unread favicon at the time of loading website. and then displaying that count regardless of how many unread you actually have.

So i think to only way to properly fix this is to also fix the other issue. i posted documentation of how firefox does it further up

Vlad

I dont see how its different. the result is "improper favicon"which is the tittle of this thread.

So the point is that "Blurry or improper favicon" most likely cant be fixed fully without at least partially fixing the other issue

Theres is nothing really new in what I'm saying in regards to the other issue, so its not interesting for the other thread. Its only interesting for this issue of improper favicon

--

Also after thinking about it, perhaps my example of github dark mode/light mode can be fixed without fixing the other fully.

Since it isnt the favicon dynamically updating, its the website sending a different favicon dependent on users having dark mode or light mode on. and Orion storing the favicon without any log if it was either or, and not asking for a new one on refresh.

Which potentially can lead to other issues as mentioned above (discord message count being wrong). another example of issues it could perhaps create is if a website changed there favicon. and Orion just keeps the favicon it had when first visiting

Just tested with Gmail. as suspected after clearing favicon cache its saves the first favicon it receives which in my case was 1 unread message favicon

after reading that message. I will still have that as the favicon even after reloading page (no ask for a new favicon is happening) resulting in improper favicon:

I suppose this could be partially fixed without fixing the other issue. by Orion updating favicon on refresh, so you can disregard the mention of the other issue

Did some tests of favicons. and theres still something different about Orion compared to other browsers.

Like in general the quality is alot better. but for some reason Orion is still different, not always in a bad way.

like on BBC.com

Orion:

Safari:

sometimes you get the same as Safari, sometimes not.

https://www.bbc.com/sport/football

Orion:

Firefox:

Safari:

Thoose are just different not worse.

But in case of https://www.ifixit.com

Orion:

Safari:

Firefox:

The Orion one is alot more pixilated