Updating beta (and RC) removes toolbar customizations

ajgraves

Steps to reproduce:
Customize toolbar then install the latest update, note that toolbar is either reset to default, or messed with in some capacity.

Expected behavior:
Toolbar customizations should stay between upgrades

Orion, OS version; hardware type:
Orion Version 0.99.121-beta (WebKit 614.1.20)
MacBook Pro (macOS Monterey 12.6 build 21G115)

Image/Video:

Orion 0.99.121-beta (WebKit 614.1.20)
macOS Version 12.6 (Build 21G115)
MacBookPro18,3

Session Info:

Open windows => 1
Pinned tabs => 0
Active window tabs => 2
Active tab url => https://orionfeedback.org/

Enabled Extensions:

Dark Reader (firefox)
Bitwarden - Free Password Manager (firefox)
Raindrop.io (firefox)
Go Incognito (chrome)

Disabled Extensions:

Non Default Settings:

AlwaysShowToolbarInFullScreen => 0
AutofillEnabled => 0
PreferredBookmarkFolderId => B393066B-0AE8-431B-B960-4D01A06754C2
BookmarksShortcutEnabled => 0
ContentBlockerLastUpdated => 2022-10-21 00:00:00 +0000
CustomAppIcon => appicon2
isBackgroundImageDarkOnStartPage => 1
overflowMenuItems => (
historyButton,
webInspectorButton,
notesButton
)
WebAutomaticSpellingCorrectionEnabled => 1
WebContinuousSpellCheckingEnabled => 1
WebAutomaticQuoteSubstitutionEnabled => 0
WebAutomaticDashSubstitutionEnabled => 0
ShouldShowWelcomeAnimation => 0
ToolbarConfiguration => {
"TB Default Item Identifiers" = (
windows,
navigationGroup,
NSToolbarFlexibleSpaceItem,
privacyButton,
websiteSettingsButton,
locationBar,
bookmarkButton,
addTabButton,
NSToolbarFlexibleSpaceItem,
shareButton,
tabOverview
);
"TB Display Mode" = 2;
"TB Icon Size Mode" = 1;
"TB Is Shown" = 1;
"TB Item Identifiers" = (
windows,
navigationGroup,
NSToolbarFlexibleSpaceItem,
privacyButton,
websiteSettingsButton,
locationBar,
bookmarkButton,
addTabButton,
NSToolbarFlexibleSpaceItem,
"webExtButton-9b4ed380af7615779f4d1213b2934dfe",
"webExtButton-oimfnddepdafdfmammggkfmdepfmipai",
"webExtButton-73165377b43b01f953b4b8889bf9f86d",
"webExtButton-c27d4c059acb1307dc721a3a46654d06",
shareButton,
tabOverview
);
"TB Size Mode" = 1;
}
OpenSafeFileAfterDownload => 1
FirstLaunch => 0
FirstTimeWebExtensionNotice => 1
HomePageURL => orion://newtab/
ShowErrorIndicator => 0
LastUsedBuildVersion => 121
WillInstallUpdate => 0
PreCompiledContentRuleListVersion => 121
LastCrashCheckDate => 2022-10-22 04:07:05 +0000
LowPowerMode => 0
NextDownloadID => 52
OpenNewTabsInForeground => 1
SavedWindowSize => 1620.0,979.0
SavedWindowPosition => 21.0,62.0
BookmarksBarVisible => 0
BookmarksSidebarVisible => 0
BookmarksSidebarWidth => 241.5
QuitWithConfirmation => 0
ActiveLibraryTab => extensions
UseTabSwitcherUI => 1
TabSwitchingOrder => byRecentlyUsed
SyncEnabled => 1
BookmarksLastSynced => 1666411626202.847
ReadingListLastSynced => 1666411626203.577

ajgraves

This doesn't seem limited to first start after upgrade. Orion locked up on me and I had to force quit it. After starting it back up, I lost the controls for the tab overview, new tab, and share sheet. All were in their default location except the new tab button.

mentee

I don't know if it's exactly the same bug but at one point I had lost most of the toolbar items, including the default ones.

orionborion

Steps to reproduce:
To reproduce just open a new orion window.

Expected behavior:
I expected to see the window browser icon (the 4 squares) and to scroll through the tabs with a swipe left or right. The left most tab is cut off and doesn't have an x and any tabs past the left tab are inaccessable. When I go to edit the toolbar icons a box appears in the middle of the settings and says "overflow menu" and blocks the usuability of the customize toolbar section. I cannot get rid of this box and it blocks other icons. Not all icons that I put in the toolbar are displaying. This was all working before the update to fix YouTube high CPU usage. Broke after update.
Orion, OS version; hardware type:
Version 0.99.121.1-beta (WebKit 614.1.20)
MacBook Pro (macOS Big Sur 11.6.8 build 20G730)
Image/Video:

M_L_M

I have also noticed problem with items disappearing from toolbar. In my case only "New Tab" and/or "Tab Overview" disappear when they are placed on rightmost side. Also they disappear only after opening two New Windows (doesn't matter if private or not).

Tab scrolling bug is discussed here.

I have no problem with Overflow Menu edit window. This window can be moved or closed in my case.

macOS Monterey 12.5.1 build 21G83
Version 0.99.121.1-beta (WebKit 614.1.20)

ajgraves

Ok, this is incredibly hard to chase down exactly what's happening, but every now and then I notice randomly that the same three items (new tab, share, and tab overview) are missing from my toolbar, without restarting or updating. Just during the normal course of using the browser, at some point I notice those three missing again.

M_L_M

ajgraves Did you always have all three items beside each other all on the right side? Like you had in the video before updating?

ajgraves

M_L_M Yes, that's where those three always sit in my configuration. That is the default position for the tab overview and share buttons, however the new tab button is out of its default spot.

M_L_M

ajgraves In my case that items disappear only if I place them on the right. And then always disappear after opening two new Windows or reopening Orion two times or any combination of these steps.

ajgraves

M_L_M I haven't tried putting other controls on the far right to see if they get affected (I'm very much a creature of habit; once I have a layout set it tends to stay). However, I can say I typically notice it when closing/re-opening Orion, however in this most recent instance, I hadn't restarted Orion, it's just been there running a few days, and suddenly I noticed those controls gone again.

ajgraves

One thing I've just noticed today is clicking something that triggers a popup window seems to trigger the removal of the controls from the toolbar. Maybe try that in the investigation, see if you can duplicate.

M_L_M

I tried popup windows too with same result as opening new Window. After two popup windows opened "New Tab", "Tab overview" and "Share" button disappear if they were placed on the right side.

ajgraves

@Vlad seems to be reproducible if you place those icons on the right side of the toolbar and then go through operations such as opening a new window, triggering pop-ups, etc.

ajgraves

Installed the most recent update, and opening a new window still triggers the loss of these controls from the toolbar on opening a new window. Hopefully this one can get narrowed down and fixed soon! It's frustrating to have to keep re-configuring my toolbar.

Vlad

ajgraves Yep we didn't time to fix this one in this release

Tommy

Steps to reproduce:
When I add addon icons to the toolbar, after only a couple of minutes, or if I close and open Orion, the "New Tab" icon disapears. No matter how many times or where will I place it in the toolbar, the new tab icon will disapear again, and it happens only with the new tab icon. Additionaly, it happens to more than one installation, in more than one of my devices so it's reproducable on my side.

Expected behavior:
New Tab toolbar icon should stay at the place the user places it at all times.

Orion, OS version; hardware type:
Version 0.99.122-beta (WebKit 615.1.11.7)
MacBook Pro (macOS Ventura 13.1 build 22C65)

Image/Video:

ajgraves

I believe this is the same as https://orionfeedback.org/d/3384-updating-beta-and-rc-removes-toolbar-customizations, which seems to be fixed in the RC builds, so should be fixed in the main beta on the next release.