4
  • Clicking LocationBar Fires animations for LocationBarTextView while in focus

  • BugsDesktopDone

Steps to reproduce:

  1. Click on the search field
  2. When in focus, click in the empty space in between the bottom of the field and the LocationBarTextView (aka: the text)

Expected behavior:
Nothing. Possibly however the text could be selected at the mouse's x position or the cursor gets placed there. That would either require the bounds of the LocationBarTextView to stretch across the entire search field, or some wacky event listening. The former would also break text centering so idk.

Orion, OS version; hardware type:

MacOS 12.0.1

Image/Video:

Here you can see where exactly to click. Anything that isn't highlighted in blue will trigger the focus animation

PS: In safari, the text of the UnifiedFieldEditor is properly aligned to the vertical center of the search field. Here it is not.

    While I am able to reproduce this, I'm not sure this is really an issue. Does it not make sense to focus the address bar if it is clicked, even if not directly on the text?

      saul Accessibility wise, yes it makes total sense. However (correct me if I'm wrong), with accessibility you aren't supposed to be confused as to whether it is a bug or not. If the intention is what you speak of, the bug doesn't exactly lie in the existence of the animation, but the animation itself. Instead of being a clear indicator that the focus has moved to the text, or even suggesting that the text is already focused, it just flashes the text moving back to center implying that it is glitching trying to un-focus the text.
      I understand how this is working too (it is not intended).

      When you click anything other than the LocationBarTextView it tries to change the focus of the search bar to being in idle (ie: No one is gonna be typing in it) However, where you're clicking matters because clicking the LocationBar changes the state of the search bar to focused. The problem is that two animations are trying to go at once, and the optimal call stack will cause the search bar to lose focus first. That causes the one triggered by the LocationBar to be invalidated, and instead of the properties being animated back to the side, it just teleports there as the time in the animation context has passed anyways.

      I can't see this as being intended anyways as it requires you to click in obscure places to trigger.

      All of this is up for speculation but that's just my opinion.

      • saul replied to this.

        Since you are already focused on the address bar, it should not animate again when you click on a certain part of it. This bug is probably caused by Orion wanting to unfocus and refocus the address bar together.

        Yeah that's a less confusing way of describing it lol.

          Cero Oh shoot, sorry, I completely misunderstood what the bug was. You're right

            a year later
            4 months later

            Has been fixed in the latest version, thank you!

              No one is typing