Yomitan extension's pop-up dictionary not working properly

thrzl

To reproduce:

Install Yomitan (Firefox version; Chrome hardly works at all)
Set language to French or Japanese and install kty-fr-en (French) or Jitendex (Japanese) dictionary (these are the only two I tested)
Try to scan any phrase on any website in the chosen language.

The text highlights, but no popup appears. DevTools shows the following error:

[Error] Yomitan Popup Dictionary 25.6.3.0 has encountered a problem.
Originating URL: https://fr.lipsum.com/
Error: Comm port didn't open
@moz-extension://6b733b82-9261-47ee-a595-2dda294a4d08/js/comm/cross-frame-api.js:444:24

Issues can be reported at https://github.com/yomidevs/yomitan/issues
	logGenericError (log.js:138)
	error (log.js:65)
	(anonymous function) (frontend.js:787)

This is the desired result (screenshot taken from Floorp, using the same text on the same page I tested Orion with.)

The popup dictionary should have appeared beneath the text, and no error should have appeared in DevTools.

Version 0.99.133-beta (WebKit 621.1.2.111.4) on macOS Sequoia 15.5 build 24F74

Sequoia (15)

4j0

same exact issue with the firefox version of the extension I couldn't get the chrome one going very well.
🙁
Version 0.99.135.0.1-beta (WebKit 622.1.15.19.2)

thrzl

I was viewing the Orion User Guide (the Focus Mode page specifically) when Yomitan suddenly gained full functionality for a moment. I was able to select multiple words and view definitions, everything worked as it should, before it eventually stopped working and went back to the way it was before. I haven't been able to reproduce this yet.

ClaireBillault

Yomitan works partially if you open a search window, and copy the term you want to search

However, the popup doesn’t work, but this might be because ALL pop-ups are blocked in iOS/iPadOS Orion. There is a request to allow pop-ups or at least allow people to chose whether they want pop-ups from months ago, but so far it hasn’t been implemented.

thrzl

ClaireBillault
I was aware that I could use the search window, but that adds a lot of friction and it gets to the point that I'd rather just use another browser, especially since I'm trying to immerse so I'm often dealing with unfamiliar terms

As for the popups, macOS doesn't seem to have the same issues, according to https://webbrowsertools.com/popup-blocker/. Both their test and (most of) the popup functions work. But, after looking into it a bit more, I found that the immediate error is referencing this function, which looks like it's failing to communicate with the popup:

https://github.com/yomidevs/yomitan/blob/972535f522b22c51f7cabb7193f1eac6a143859d/ext/js/comm/cross-frame-api.js#L429-L445

/**
     * @param {number} otherTabId
     * @param {number} otherFrameId
     * @returns {Promise<CrossFrameAPIPort>}
     */
    async _createCommPort(otherTabId, otherFrameId) {
        await this._api.openCrossFramePort(otherTabId, otherFrameId);

        const tabPorts = this._commPorts.get(otherTabId);
        if (typeof tabPorts !== 'undefined') {
            const commPort = tabPorts.get(otherFrameId);
            if (typeof commPort !== 'undefined') {
                return commPort;
            }
        }
        throw new Error('Comm port didn\'t open');
    }