Reader mode gets incorrectly turned on, when it isn't supported

eirk

Steps to reproduce:

GO to a website that doesn't support reader mode, eg https://orionfeedback.org
press the reader mode button in the address bar (if it's not there, it should appear when you hover over it)
observe the correct warning saying that reader mode isn't supported
click on site settings, and observe that reader mode is "turned on", even though it shouldn't be.

Expected behavior:
reader mode should not be enabled. I just mean that the checkmark should not be there.

Orion and macOS:
Device: 2020 13" M1 MacBook Pro
OS: macOS Monterey 12.1 (Build 21C52)
Orion: Version 0.99.109.1.1-beta (WebKit 613.1.12)

Image/Video:
https://cln.sh/nc2hr7

Vlad

eirk Reader mode turns on as it is a per site setting and you've shown intent to read this site in reader mode. If you visit a page that is viewable in reader mode it will be shown as such.

Fortrikka

Is it possible to make reader mode only shown on user input? By default off.

plateau

Sometimes when I'm on some internal webpages (LAN IP) - the reader mode icon shows alongside the "aA" icon to change e.g. to sepia background, but that has no effect on the page as it isn't reader mode compatible.

I expected it to not display at all, but at least if reader mode icon does trigger, that the aA options are hidden, due to them not actually having any effect when I click through them.

Orion, OS version; hardware type: Version 0.99.121-beta (WebKit 614.1.20)

Vlad

This was a wrong merge. But we should not show reader mode aA icon on a page where reader mode is not owrking (even though it is enabled)

nrudnyk

Vlad But we should not show reader mode aA icon on a page where reader mode is not owrking (even though it is enabled)

not this works as expected:

hence marking this Done

mentee

After trying to activate the "Reader Mode" and a dialog informs us that it is not available, its icon in the address bar becomes active (blue) and the icon of its options appears.

Orion version: 0.99.121-beta