Extension shortcuts precedence over website and browser shortcuts.

Fortrikka

Title.

Cannabat

FF and Chromium ignore extension shortcuts which conflict with browser shortcuts and have separate menus in which all extension keyboard shortcuts are set and can be modified by the user.

Orion needs to both ignore shortcuts which conflict w/ browser shortcuts, and provide a UI to customise shortcuts as defined in extension manifests

Vlad

@Fortrikka
If an extension overrides cmd n (new tab in browser) you would expect it to do so?

Fortrikka

Vlad I would suggest that they be ignored.

tommi

Hello, me too I am experiencing trouble since none of my extensions shorctuts work. For example, to open Wallabager in Firefox I click on ⎇ + W, and in Orion if I click this nothing happens.

Vlad

It is not clear what the exact ask is here?

Karrq

I think this may be referred to search shortcuts. I also recently switched from firefox and I am an avid user of https://rust.extension.sh, where the extensions allows you to search docs just by typing rs in the url bar and then your query.

I can go around this by using bangs (DDG or Kagi), but the extension also allows local caching and indexing also of local documentation, in addition to other libraries.

I was very sad to see this feature disabled, or at least I wasn't able to use it in Orion after I installed the extension.

EDIT: I realized now it meant keyboard shortcuts. I couldn't find another issue about the other type of shortcut I listed above tho...

eirk

i think that the shortcut precedence should be (from highest to lowest)

app
extension
website

so, the cmd-n shortcut can never be overridden.
this also means that extensions can override shortcuts set by a website

eirk

turns out this is a dupe and discussion here was meaningless as it was discussed in much greater detail https://orionfeedback.org/d/112-attempting-to-use-the-minimize-shortcut-in-netflixcom-mutes-the-video/5

Fortrikka

Bug Report

Steps to reproduce:
Minimize window shortcut while viewing a video on Netflix.

Expected behavior:
Minimize the tab.

macOS:
11.5

Vlad

Which one is the minimize window shortcut?

I think it was you who asked that website shortcuts take precedence over app shortcuts (and we did that). What is your guidance?

Fortrikka

Vlad Yes, it was me but Netflix does not use command+m. I use Safari and it works with Netflix and Youtube and also enables google meet's command+d shortcut to take precedence over Safari's own shortcut. It is a bit different in Orion's case.

Fortrikka

Vlad No the issue with this bug report in the first place is that command+m should minimize the tab as netflix does not have any shortcut which utilizes command+m, as checked with Safari. Somehow Orion does not let the website ignore the "command" key or rather know that it is being toggled and subsequently Orion does not know what to do with the next "m" so it passes it through the website confusingly. The expected behavior is that upon pressing command, it should check if the website has any shortcuts for that specific key that is going to be pressed next, but if not then pass it through the browser. But that does not appear to happen because in Orion, it mutes the tab instead of minimizing it while in Safari, it minimizes the tab immediately signifying an issue with how shortcuts work.

pieterv

… it would be nice if you could press "N" to create a new post

@Vlad https://discord.com/channels/802933355603034132/897207822939455538/902952419758075944

…keyboard shortcuts like \ and N are active now…

I don't know how website shortcuts used to work before, and how they're supposed to work according to standards.
But this is how it works in Safari:

When on OrionFeedback cmd+N opens a new window, while only N opens the new feedback form.
When on Netflix watching a video cmd+M minimizes the window, while only M toggles mute in the Netflix player

this is how it works in Orion:

When on OrionFeedback cmd+N opens the new feedback form., while only N does nothing.
When on Netflix watching a video cmd+M toggles mute in the Netflix player, while only M does nothing.

Fortrikka

pieterv It should be made to how it works in Safari as that is standard. Even in Google Chrome. I guess some issue is that the command key is being added even though both browsers are still webkit?

saul

To add, I think "crucial" shortcuts should always override (new tab, new window, new incognito window, and focus address bar to name a few) however some of the auxiliary shortcuts (cmd + y for history, cmd + f for search, and cmd + u for focus mode for example) should pass through and prioritize any website shortcuts that may occur

Fortrikka

saul The one tiny issue is that Google made command+D the bookmarking shortcut a shortcut to toggle the microphone in google meet.

Vlad

@Fortrikka @saul @pieterv

Help us understand how things should work. There is no such thing as a list of 'crucial shortcuts'. Based on the previous request, we have simply passed keyboard input to web app so it has precedence over browser.

We appreciate concrete suggestions with examples. Thanks!

saul

Vlad I'm not too sure how Chromium does it, but it seems to handle passthrough quite well. In terms of "crucial shortcuts", these would be shortcuts that allow you to navigate the browser (cmd + Q, cmd + L, cmd + n, cmd + shift + N, cmd + T, cmd + shift + t, cmd + M, and probably a few others that I am forgetting).

Essentially the goal is to pass the maximal amount of shortcuts through that don't cause you to lose any browser functionality

Vlad

saul We are looking for a definition of what is browser functionality. A list of sorts that we can whitelist.