4

  • Bookmark invokations should fall under "Bookmarks" autocomplete label, not Top Hits

  • BugsDesktopDone

First screenshot is me typing my bookmark invokation (yt for youtube search), and the top result returns labelled as "Top Hits". I have Top Hits disabled under autocomplete suggestions, so this shouldn't make sense to appear in the first place.

Second screenshot, I backspaced the t in yt and recompleted it as you. This returns the search of you in my bookmarks, but "Top Hits" is still included as the top result (even though it should be disabled). It makes more sense for the bookmark invokation shown in the first screenshot to have this same bookmark label.

Orion Version 0.99.126.1-beta (WebKit 618.1.2)

Sonoma (14)

    I should add for the second screenshot's case, if I fully delete the search keyword and type in you again, I only get back the Bookmarks suggestions. Makes sense since you isn't my bookmark invokation, but the difference there shouldn't exist as long as the search term remains the same.

    The difference I'd expect if I DID set my bookmark invokation to you is that the corresponding bookmark is highlighted and pressing enter goes to the bookmark, whereas if I had no bookmark invokation then nothing is highlighted and pressing enter starts a search for "you".

    • dino replied to this.
      8 days later

      minte So basically we need here is-

      1. When Top Hits are disabled, there should be no Top Hits section in completion list
      2. When we have matching invocation bookmark, it should be in Bookmarks label (without duplicating it)

      Correct me if we are not on the same page.

      We have a few questions (when Top Hits are disabled)

      1. Should the invocation bookmark still auto select?
      2. Should it be still in top of the list (above Search Suggestions section)
      3. What should be the label the invocation bookmark should have? like we already have a separate Bookmarks section in bottom below search suggestions.

      cc @eirk

          dino My opinon on your questions:

          1. Yes it should still auto select because I should be able to type in my invokation and press enter immediately to quickly access bookmarks.
          2. Yes, invokations are set by the user and so I would expect it to override anything else in the suggestions bar. If someone has issues with this then they could easily change their invokation to not interfere with what they want to appear.
          3. Not too sure about this, I would think "Bookmarks" works but if you don't want it to overlap with the separate Bookmarks section then "Bookmark" or "Invokation" could be more options?

              minte Thank you for confirming the spec. I implemented it, but just to confirm the implementation is correct, could I send you a new dev build of Orion to check and ask if you can make sure it's behaving as expected? You can DM me on Discord, where my handle is also "astruckm" 🙂

                  4 months later
                  No one is typing