More consistent edit options for profiles, windows, and bookmarks

eirk

bookmarks

Orion:

Bookmarks have these two options of interest:
Rename... this should nothave ... because it doesn't open any popup
Edit this should have a ... because it opens a popup

Safari for reference:

profiles

Profiles have these options:

these options are of interest:
Settings... this should be Edit... to be similar with all other options
There should also be a Rename option, to be consistent with the bookmarks edit options

windows

Windows have these options:

these options are of interest:
Settings... this should also be Edit...
There should also be a Rename option, to be consistent with the bookmarks edit options

Vlad

eirk Good idea to poke around this. Context is not same though Windows and Profiles have actual settings there which is why we renamed this to Settings. What gives?

eirk

I'm not sure what makes it special to have it called Settings...
You're still editing the window/profile configuration. I've never seen Settings... in any macOS app, so i'd really hesitate before using it

Vlad

eirk Because there are options to set? It is not just editing a name.

eirk

Vlad Still, even bookmarks have the Edit (actually should be Edit... option), but it change more than just a name.

Edit means to edit one or more field correlated with that item, which i think makes a lot of sense here