Vertical–horizontal tabs switching needs to be separated from show/hide tabs sidebar

phy

TLDR: Separate features to "Show/Hide Vertical Tabs Sidebar" and "Show/Hide Horizontal Tabs".

Because "Show Vertical Tabs Sidebar" shortcut is overloaded with resposibility of switching tab styles, there is inconsistent in behaviour against all the other show/hide sidebar shortcuts.

Repro (faster with keyboard shortcuts):

Switch to Focus mode.
Select Show Sidebar
Sidebar switches in place (as expected) with options:
- Show Windows Sidebar
- Show Bookmarks Sidebar
- Show Reading List Sidebar
Only option for tabs is Show Vertical Tabs Sidebar, which makes the sidebar disappear.
Selecting Show Vertical Tabs Sidebar again does nothing. Sidebar remains hidden.

To get the vertical tab sidebar in Focus Mode back again, you have to make sure it's enable and then show the sidebar.

Vlad

phy How woud you structure this option in the menu?

phy

View menu would just need one extra item "Show/Hide Horizontal Tabs". Putting it at the end keeps all sidebar-related items together:

Show/Hide Sidebar
Show/Hide Windows Sidebar
Show/Hide Bookmarks Sidebar
Show/Hide Reading List Sidebar
Show/Hide Vertical Tabs Sidebar
Show/Hide Horizontal Tabs

"Show/Hide Vertical Tabs Sidebar" would have the singular purpose of doing just what it says. No weird switching.

Show tabs in Settings > Appearance becomes redundant and can be cleaned out for more interesting options.

Vlad

phy Can you walk through your previous examples and what the state of these options would be?

phy

After investigating further, I found two bugs and a simpler fix.

First one: For the screenshot below, I have opened the Vertical Tabs Sidebar then selected Main Menu > View > Show Windows Sidebar to make Windows the active sidebar. Now the menu and (consequently keyboard shortcut) can no longer switch back to the Vertical Tabs Sidebar because its option is stuck on "hide":

"Hide" should be the option only if it is the currently active sidebar. Vertical Tabs is the only one not behaving like this.

Second bug is in Focus Mode: Main Menu > View > Show Vertical Tabs Sidebar doesn't open the sidebar as it should. Once open, as above, this would change the menu option to Main Menu > View > Hide Vertical Tabs Sidebar and allow it to be closed like the other sidebars.