Favorites do not appear on home page

viewsourc3

Steps to reproduce:
Favourites do not appear on startup page. (Plus I get a weird icon for tab overview...)

Expected behavior:
I expect favourites to be added on startup page.
I have tried to uncheck and recheck the option in the settings, but favourites still do not appear.

Orion, OS version; hardware type:
1.2.3 (1) (WebKit 8614.3.7.0.6)

Image/Video:
Startup page:

Favourites:

viewsourc3

@OFBack

nanoscrew

Hi @viewsourc3, I'm looking into this issue, and I'm having trouble reproducing it. I'll add more bookmark-debugging logs to the next version of Orion, at which point if you're still dealing with this issue, we can go through steps to send logs to us that will help find the root cause of this.

isametry

Vlad nanoscrew I'm having the same issue, and this is probably the key part to reproduce it: the language has to be non-English.

The bookmarks folder where favorites are stored (or pseudo-folder, I'm not sure how it works under the hood) is always called Favorites [verbatim in English], no matter what the UI language is.

(By the way, maybe this deserves a separate bug report? The word Favorites should definitely be localized on the front end.)

Anyway, the problem seems to be that if the language for Orion is not English, either due to system settings, or the per-app preference for Orion in particular, the Start Page UI fails to retrieve the actual bookmarks from the Favorites folder. (Possibly because it's looking for the localized term, rather than the English one?)

The bug only happens on iOS. On Mac, while the heading again shows the non-localized, English word "Favorites", they are still indeed shown.

See screenshots below – if the app-specific language for Orion is set to Czech vs. English. The favorites are only missing on iPhone.

Lulu

Simple bug: If I choose to show my favourites on the startpage in the settings, they are not shown

App version: 1.3.2 (1) (WebKit 8615.3.12.10.2)
System version: 16.6.0
Device type: iPhone 13 Mini
Native bounds: (1080.0, 2340.0)
Scale: 3.0
Regular tabs: 1/1/1/orion://newtab/
Private tabs: 0/0/0/(

Vlad

Lulu I am not sure I cna reproduce this. Can you show a video?

ForumNinja404

Lulu Have you tried closing the start page and creating a new one? Sometimes those changes won’t apply on the current one, and are only reflected on new tabs.

Vlad

isametry Thanks, good hunting there!

Michal

Do you still see this problem? I spend quite a bit time in different locales trying to reproduce but no luck so far