Steps to reproduce:
- Unzip and install the attached extension
- Open the console for "Test extension 3"
- Open a browser window and navigate to a web page, such as https://kagi.com, and make sure the browser window has keyboard focus
- Type: Control+Shift+U
- Type: Command+B
- Type: Control+B
- Type: Control+N
- Type: Command+K
- Type: Control+K
Expected behavior:
In the console output for "Test extension 3", the following should be printed:
onCommand! test_ctrl_shift_u
onCommand! test_command_b
onCommand! test_ctrl_n
onCommand! test_command_k
This is what gets printed in Chrome, as well as Firefox (so long as its normal app-wide keyboard shortcuts for Command+B and Command+K are disabled)
Actual behavior:
In the console output for "Test extension 3", the following is what actually gets printed:
(2) onCommand! "test_command_b"
onCommand! "test_command_k"
(Note the first line is repeated twice.)
So several of the commands defined in this extension do not work in Orion.
The keystrokes for these extension commands are defined thusly:
"test_ctrl_shift_u": {
"description": "Doesn't work in Orion",
"suggested_key": {
"default": "Ctrl+Shift+U",
"mac": "MacCtrl+Shift+U"
}
},
"test_command_b": {
"description": "Partially works in Orion, Command+B triggers it but so does Ctrl+B",
"suggested_key": {
"default": "Ctrl+B"
}
},
"test_ctrl_n": {
"description": "Doesn't work in Orion",
"suggested_key": {
"default": "Ctrl+N",
"mac": "MacCtrl+N"
}
},
"test_command_k": {
"description": "Works in Orion",
"suggested_key": {
"default": "Ctrl+K",
"mac": "Command+K"
}
}
The issue is that Orion does not handle Ctrl and MacCtrl according to specs for extension commands.
Ctrl is supposed to be interpreted as the command key on macOS, and typing Command+B does correctly trigger test_command_b. However typing Ctrl+B also triggers it erroneously.
MacCtrl is supposed to be interpreted as the actual control key, but Orion doesn't recognize this, so test_ctrl_shift_u and test_ctrl_n don't work.
test_command_k is the only one that works properly, as typing Command+K triggers it, but not Ctrl+K.
Orion, OS version; hardware type:
Orion 0.99.113.2.1-rc (WebKit 614.1.12)
macOS 10.14.6
