AppleScript Enhancements / Compatibility with Safari

AndroidKitKat

Steps to reproduce:

Paste this script into /Applications/Utilities/Script Editor.app

tell application "Orion"
	
	--Variables
	set windowCount to number of windows
	set docText to ""
	
	--Repeat for Every Window
	repeat with x from 1 to windowCount
		set tabcount to number of tabs in window x
		
		--Repeat for Every Tab in Current Window
		repeat with y from 1 to tabcount
			
			--Get Tab Name & URL
			set tabName to name of tab y of window x
			set tabURL to URL of tab y of window x
			
			set docText to docText & "<a href=" & "\"" & tabURL & "\">" & tabName & "</a>" & linefeed as string
		end repeat
		
	end repeat
end tell

--Write Document Text
tell application "TextEdit"
	activate
	make new document
	set the text of the front document to docText
end tell

Run it
With Orion, you get an error: error "Orion got an error: AppleEvent handler failed." number -10000

I know that AppleScript is pretty old and crusty, but I think this 'bug' is in the "tab" implementation of Orion's AppleScript handler.

For this specific behavior, it could probably be re-implemented with a browser extension, but I also use the AppleScript functionality of Safari in my IRC client (Textual) to quickly share what web page I am on.

Expected behavior:
The AppleScript behaves as it does if you were to replace "Orion" with "Safari" which is opening a text document with every URL and it's title

Orion, OS version; hardware type:
Orion version: Version 0.99.111-beta (WebKit 613.1.12)
macOS version: Version 12.2 (21D49)
Hardware type: MacBook Pro 16, M1 Max

Image/Video:
Video Attached:

Vlad

AndroidKitKat It would help if you debugged which concrete commands are failing. Orion has some AppleScript support, but not all. Help us prioritize.

juandesant

I'm also interested in this bug. The issue is triggered by the fact that

tell application "Orion" to get the windows

returns many more windows than expected. My Orion Window menu only has one Window, as shown in the attachment:

but the result of the code above is:

{window id 12157 of application "Orion", 
 window id 11331 of application "Orion", 
 window id 11541 of application "Orion",
 window id 11536 of application "Orion",
 window id -1 of application "Orion",
 window id -1 of application "Orion",
 window id -1 of application "Orion"}

If I try to find out how the other windows are different, with code like this:

tell application "Orion"
	repeat with theWindow in the windows
		get properties of theWindow
	end repeat
end tell

It fails with the same error "Orion got an error: AppleEvent handler failed." number -10000 error message on the second window.

So there is probably some hidden windows or window-like objects being reported by get the windows that are not true Orion document windows.

Vlad

juandesant Thanks for details, very helpful to debug.

PhilMac

CarbShark Vlad

I think what's happening is that Orion is returning results for windows that have been closed

Indeed. This has been noted in the MacScripter forums:

I noticed that the Orion app doesn't forget windows after they're closed. For example, in my browser there's only 1 open window, but Orion returns 16 windows from the number of windows command.

CarbShark

I think what's happening is that Orion is returning results for windows that have been closed and no longer exist, so commands to windows that aren't there will fail.