SidebarAction.open is defined yet fails on iPad

jeurissen

Extensions expect the sidebarAction API to work if it is available in scope.

sidebarAction.open returned promise rejects with the following error:
Unhandled Promise Rejection: unable to find toolbar item

1.4.16 (10) (WebKit 8624.2.5.10.4)

jeurissen

It would be good to know as developer how to detect sidebarAction/sidePanel support without having to rely on unreliable isMobile checks.

jeurissen

The sidebarAction.isOpen for example never resolves or rejects on Orion on iPad.

nrudnyk

jeurissen

we'll make sure sidebarAction.isOpen either resolves or rejects

nrudnyk

@jeurissen i guess ideally we shouldn't declare this api for ipad so you can do something like

if (typeof browser.sidebarAction !== 'undefined')

untill it's fully implemented.

nrudnyk

i guess we can't simply remove it, so for now we'll complete a promise with clean error message, something like so:

jeurissen

Thanks for taking a look at this issue and making isOpen work!

What is the specific reason sidebarAction is required to be defined on iPad and iOS? Ideally we would have a synchronous way of detecting sidebarAction support. Currently we have to rely on using either useragent/touch support sniffing, or use the async getPlatformInfo API.

As far as I know Firefox Mobile also lacks the sidebarAction yet also does not declare it.