Chrome.action.setPopup({ popup: null }) incorrectly removes the popup

jeurissen

When an extension calls:
chrome.action.setPopup({
popup: null
});

It expects the browser to restore the popup to the original value specified in manifest.action.default_popup. However in Orion currently it completely removes the popup from the action all together.

Keep in mind when calling it with an empty string:

chrome.action.setPopup({
popup: ""
});

The browser IS supposed to remove the popup completely.

To restore the popup back to manifest.action.default_popup.

Version 0.99.138-beta (WebKit 623.1.8.0.0)

Tahoe (26)

nrudnyk

@jeurissen first of - thanks for reporting this!

I wonder whether you have a simple sample extension where we could test broken behavior? That would simplify and speed-up the process. Thanks!

jeurissen

@nrudnyk thanks for your reply! Any extension with an extension popup will do. You can reproduce the issue by right clicking the action popup, click on inspect element, and call chrome.action.setPopup({ popup: null }); in the popup. Attempting to reopen the popup will now fail.

See mdn documentation as well:
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/action/setPopup#popup