Mobile: Tab previews are missing (still)

Haarolean

A follow-up for #5557 as requested by @Vlad:
I'm still missing some tab previews on mobile. Mostly, it's google search ones, favicons are missing as well.
Attaching 4 screenshots:
1) google (I have a decent google search tabs with missing (black preview)
2) hackernews (found only one tab, usually they're ok)
3) youtube (found only one as well)
4) some random site, link here

expected to have the previews

1.3.18

Haarolean

I think the google ones are black because the URL is not actually google's but like long%20distance%20film, basically URL-encoded search string I did input (google is my default search engine on this device). Once I click the tab, in re-renders, but it searches the string in google without actually URL decoding it, see screenshot attached.

jeanetienne

Hi Haarolean thank you for taking the time to report this bug!

I know I have seen these issues as well, and I wnat to find a fix for them, but I haven't been able to consistenelty reproduce them. Do you have by any chance a fool-proof way to reproduce either of these issues:

the Google-url percent encoding issue
the overall tab preview image being black issue

Thank you for your help in making Orion a better browser!

Haarolean

jeanetienne I don't know the exact steps to reproduce this cleanly but I'll keep looking.
One thing I recently noticed -- I don't have a preview (black tab) when opening a new link via "open in a new tab", if I don't switch there and let it load the preview will remain black.

jeanetienne

Hi Haarolean, thank you for following up. Unfortunately I haven't been able to reproduce the issues with the previews/snapshots being missing yet. However I think I found the bug causing the %20 to appear in some searches. This should be fixed in the next release.

Please let us know if you find more precise reproduction steps to exhibit the bug where snapshots are missing.

Thank you for your help in making Orion a better browser!

Haarolean

jeanetienne do you build thumbnails based on URLs by any chance? If the URL is later replaced with the one with the encoded URL instead, this might explain it. I'll take a look once RC/beta with the fix you mentioned is released. Thank you!