GitHub site works not well

vladimir

Hello, Hello,

I started using Orion and all good, everything works fine, but GitHub site, especially work around Pull Requests, like making suggestion or opening big PR works very slow, when you click "add suggestion" you wait a sec to see textarea and then you wait few secs before it will allow input.
It could be on my side, but it doesn't work like that in other browsers. I could provide more debug info if needed.

In Safari it works a bit better, you still wait for textarea to appear, but you can input text straight after it.

so,

Open Pull Requests
Open diff
Click "add suggestion"
Try to input text

I would expect it to appear and work right after click
I would expect github pull requests related pages to load faster, as now navigation is slow

Version 0.99.131.0.1-beta (WebKit 621.1.2.111.4)

Sequoia (15)

dino

vladimir Can you please compare this with Safari too? just to check if this is something WebKit specific or Orion specific.

jclermont

For what it's worth, GitHub has gotten very slow in Safari recently as well, especially on large pull requests. I'm not sure this is unique to Orion. I think GitHub is over-optimizing for Chrome.

vladimir

hello @dino 🙏

I could for sure say that it works better on Safari: my test scenario:

I open Pull Requests tab
navigate to one PR
return back
navigation to next PR
open diff
click to some line to add a suggestion
type suggest and submit

Safari does everything fast enough, but for step 6 you need to wait a bit before it will show popup with textarea (in Chrome or FF it is instant). In Orion, navigation on the site slow, it could even freeze. step 6 the same – you need to wait, but in comparison with Safari you also need to wait before start typing as everything freezes.
because of this I have to use Brave for GH 🙁

charcole

similar issue for me, but it's not just on large PRs.

basic actions in a repo like opening a dropdown menu - all extremely slow. 5-10s delay minimum before the page becomes interactive again, possibly several minutes or it just hangs forever.

on a large PR it breaks down to the point of becoming almost unusable. I've had to switch to using chrome to interact with github.

I just tested on Safari as well - no other open tabs, no history or anything, since I don't use Safari. It's fairly slow; not as bad as it's been in Orion, but definitely not snappy like it is on chrome.

...it's astonishing how bad it is - but I assume it's Microsoft shenanigans, as I've seen catastrophic slowdown in VSCode with the Copilot extension enabled (copy and paste a line could take 10s), and Copilot is totally intertwined with GH now.

I'd gotten a little bit of reprieve after restarting my system entirely and reopening my last window, but that's not guaranteed and it doesn't last long.

bitwalker

Yeah this has started to actually make doing work in Orion difficult. I'd say all but the tiniest PRs are abysmally slow to review - just trying to add a comment on a line can take 10+ seconds on PRs with a couple hundred lines of changes. Anything larger than that isn't even possible to do anything with.

It sounds like this is a Safari issue too, so maybe it can't be fixed in Orion until something upstream happens, but I can't imagine there aren't people raising hell about it there too. If there is anything we can do to help push the upstream developers to prioritize this, I know I'll do what I can.

For now, I basically have to use another browser when working with GitHub 🙁

ubuntudroid

It also takes really long to just load diffs for slightly bigger PRs (not huge though, just about 1000 locs).

I usually use Vivaldi for those, and it works much better there.

nishant

I've been observing this issue as well with moderately sized PR. Especially during the initial loading of the page and scrolling through the comments as well as while adding a comment in the diff view.

I compared this with Safari and the performance was better, only marginally, than Orion. When I opened the same PR on Firefox, it was blazing fast. So this could be a WebKit but I really hope there's a way around this. Moved to using Firefox for github currently.

That said, love the work you all are doing here.